This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Add a button to reset personal encryption state during login #5819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jryans
approved these changes
Apr 1, 2021
| const cli = MatrixClientPeg.get(); | ||
| await cli.bootstrapCrossSigning({ | ||
| authUploadDeviceSigningKeys: async (makeRequest) => { | ||
| // XXX: Making this an import breaks the app. |
There was a problem hiding this comment.
Hmm, it works fine in other components... 🤔
There was a problem hiding this comment.
This dialog is loaded async for some reason, which makes it special
src/components/views/dialogs/security/AccessSecretStorageDialog.tsx
Outdated
Show resolved
Hide resolved
src/components/views/dialogs/security/AccessSecretStorageDialog.tsx
Outdated
Show resolved
Hide resolved
…g.tsx Co-authored-by: J. Ryan Stinnett <[email protected]>
jryans
suggested changes
Apr 9, 2021
src/components/views/dialogs/security/AccessSecretStorageDialog.tsx
Outdated
Show resolved
Hide resolved
gaelledel
approved these changes
Apr 9, 2021
jryans
approved these changes
Apr 13, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No public issue.
Note: This deliberately gets code review first as changes might affect how the design review goes. This needs design review to land.
Also fair warning I copy/pasted most of this in an effort to reuse existing flows.
... leads to:
